Re: master 3de31e7: Fix compilation of image.c on MS-Windows

[Andy Moreton]

On Mon 09 Nov 2020, Eli Zaretskii wrote:

>> From: Lars Ingebrigtsen <larsi@gnus.org>
>> Cc: Eli Zaretskii <eliz@gnu.org>
>> Date: Mon, 09 Nov 2020 17:04:29 +0100
>> 
>> eliz@gnu.org (Eli Zaretskii) writes:
>> 
>> >     Fix compilation of image.c on MS-Windows
>> >
>> >     This is a followup to last change in image.c.
>> >     * src/image.c (rsvg_handle_get_intrinsic_dimensions): Define to
>> >     call fn_rsvg_handle_get_intrinsic_dimensions.
>> >     (svg_css_length_to_pixels): Compile only for librsvg >= 2.46.0, as
>> >     RsvgLength type was not defined before.
>> 
>> This leads to the following warnings on Debian bullseye, apparently:
>> 
>> image.c: In function ‘svg_css_length_to_pixels’:
>> image.c:9769:13: warning: this statement may fall through 
>> [-Wimplicit-fallthrough=]
>
> Surely, not my change led to this: I only made that code be
> conditionally compiled.

True, but your change does not compile on Windows. In image.c:

#  if LIBRSVG_CHECK_VERSION (2, 46, 0)
DEF_DLL_FN (void, rsvg_handle_get_intrinsic_dimensions,
            RsvgHandle *, gboolean *, RsvgLength *, gboolean *,
            RsvgLength *, gboolean *, RsvgRectangle *));

The 3rd argument should start with a left paren.

    AndyM