[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: master a08320f: * lisp/disp-table.el (make-glyph-code): Remove obsol
From: |
Eli Zaretskii |
Subject: |
Re: master a08320f: * lisp/disp-table.el (make-glyph-code): Remove obsolete comment. |
Date: |
Mon, 09 Nov 2020 21:38:37 +0200 |
> Auto-Submitted: auto-generated
> Date: Mon, 9 Nov 2020 12:16:14 -0500 (EST)
> From: p.stephani2@gmail.com (Philipp Stephani)
>
> branch: master
> commit a08320f7234685cd84a18040556fd3f7eaacaf45
> Author: Philipp Stephani <phst@google.com>
> Commit: Philipp Stephani <phst@google.com>
>
> * lisp/disp-table.el (make-glyph-code): Remove obsolete comment.
> ---
> lisp/disp-table.el | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/lisp/disp-table.el b/lisp/disp-table.el
> index 2e88d35..70343a3 100644
> --- a/lisp/disp-table.el
> +++ b/lisp/disp-table.el
> @@ -220,8 +220,6 @@ for a graphical frame."
> ;;;###autoload
> (defun make-glyph-code (char &optional face)
> "Return a glyph code representing char CHAR with face FACE."
> - ;; Due to limitations on Emacs integer values, faces with
> - ;; face id greater than 512 are silently ignored.
> (if (not face)
> char
> (let ((fid (face-id face)))
Is this comment really obsolete? We still need to be able to pack a
face ID and a 22-bit character codepoint into a single fixnum, which
could be a 32-bit data type. See GLYPH_CODE_CHAR, GLYPH_CODE_FACE,
and SET_GLYPH_FROM_GLYPH_CODE on dispextern.h.
- Re: master a08320f: * lisp/disp-table.el (make-glyph-code): Remove obsolete comment.,
Eli Zaretskii <=