Re: [PATCH 00/10] Speeding up DEFVAR_PER_BUFFER

[Stefan Monnier]

> Here is my first attempt at speeding up DEFVAR_PER_BUFFER. I would
> greatly appreciate review/comments. This is just a first attempt and
> will certainly need some cleanup.

Thanks, this looks pretty good, thanks.

My first comment is about the commit messages: they explain the
motivation very well, but they lack the itemized description in
ChangeLog style that we like to add.
For example, for the patch 01/10 instead of

    Take buffer field name in DEFVAR_PER_BUFFER

    This removes some unnecessary usage of BVAR which would need to be
    changed later anyway.
    
    Also, this makes the comment above the define of DEFVAR_PER_BUFFER
    correct - it already says that vname is the name of the buffer slot.

We'd want something like:

    src/buffer.c: Take buffer field name in DEFVAR_PER_BUFFER

    This removes some unnecessary usage of BVAR which would need to be
    changed later anyway.
    
    Also, this makes the comment above the define of DEFVAR_PER_BUFFER
    correct - it already says that vname is the name of the buffer slot.

    (DEFVAR_PER_BUFFER): `vname` is now a field name.
    (defvar_per_buffer): Replace `address` arg with `offset`.
    (syms_of_buffer): Adjust accordingly.

I'll send further comments on some specific patches.


        Stefan