emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] tab-line-alternate-colors


From: Juri Linkov
Subject: Re: [PATCH] tab-line-alternate-colors
Date: Mon, 14 Dec 2020 11:10:06 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu)

> Okay, here's my next proposal: The tab-line-tab-face-default function
> returns a face, and then a new option, tab-line-tab-face-modifiers, is a
> list of functions, each of which is called with that face and returns
> it, possibly modified.

Thanks, tab-line-tab-face-modifiers is a good idea.  It's like hooks
used to post-process the result.  But the '-hooks' suffix is deprecated,
and the new standard is to end such variable names in '-functions'.
Then using the name tab-line-tab-face-functions will also avoid ambiguity
of the word 'modifiers' that is mostly applied to key modifiers -
there is already the option tab-bar-select-tab-modifiers.

Then tab-line-tab-face-functions will obsolete the need to have
an almost duplicate option tab-line-tab-face-function.  But then we have
two variants:

1. add tab-line-tab-face-default to tab-line-tab-face-functions by default.

2. remove tab-line-tab-face-default and leave its code in 
tab-line-format-template
   as before, with a supposition that it should be sufficient to customize
   tab-line-tab-face-functions to post-process its output face.

What variant would you prefer?



reply via email to

[Prev in Thread] Current Thread [Next in Thread]