emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] tab-line-alternate-colors


From: Juri Linkov
Subject: Re: [PATCH] tab-line-alternate-colors
Date: Wed, 16 Dec 2020 11:03:51 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu)

> Ok, I went with option 2, which moves the default-face code from the
> -tab-face-default function back into the -format-template function.
>
> Then I added buffer-p and selected-p arguments to the modifier functions
> as optimizations.
>
> This patch also includes changes for the face-related issues Eli
> mentioned, and it renames the -modifiers option to -functions, as you
> suggested.
>
> Please let me know what other changes are required.  Also, if I should
> write a NEWS entry, let me know and I'll add one.

Thanks, everything looks right.  The only thing I'm unsure about is the
default value.  I don't know how important is to highlight the distinction
between file and non-file buffers.  But it's a matter of taste, so
I can't argue against or for a specific default value.  Ideally, the
default value should reflect preferences of the most users, but even the
conducted surveys don't help, as the discussion about the toolbar indicates.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]