Re: master 9291e73 02/12: Add new 'declare' forms for command completion predicates

[Basil L. Contovounesios]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> "Basil L. Contovounesios" <contovob@tcd.ie> writes:
>
>> Why should explicit #'-quoting be needed for (declare (completion foo))
>> when it's not needed for any other declare form property, including the
>> new and related 'modes' property:
>>
>>   (declare (modes foo))
>>   (declare (gv-setter foo))
>>   (declare (gv-expander foo))
>>   (declare (obsolete foo ...))
>>   (declare (interactive-only foo))
>>   (declare (compiler-macro foo))
>>   (declare (indent foo))
>>
>> How is (declare (completion ...)) any different to these?
>
> Most of those refer to symbols (or numbers), so #'-ing is irrelevant.
> But gv-setter (for one) does refer to a function, so there's precedence
> for using symbols instead of functions here indeed.
>
> Anybody else have an opinion?

It seems there were no objections, so I applied the patch.

Function-quote completion property of declare form
752278834b 2021-02-26 11:26:22 +0000
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=752278834b3d317a65135cdaa392b0468ce7372c

Thanks,

-- 
Basil