Re: master d582356: * src/fns.c (Frandom): Handle bignum `limit`s

[Pip Cet]

On Sun, Mar 7, 2021 at 3:22 PM Eli Zaretskii <eliz@gnu.org> wrote:
> > From: Pip Cet <pipcet@gmail.com>
> > Date: Sun, 7 Mar 2021 14:21:51 +0000
> > Cc: Stefan Monnier <monnier@iro.umontreal.ca>, emacs-devel@gnu.org
> >
> > > > > I don't think I understand how will we know which function says it
> > > > > never calls GC.
> > > >
> > > > By tagging it in the source code?
> > >
> > > How do you know which functions to tag?
> >
> > That's the part I wasn't volunteering for :-) We'd have to do that
> > manually, but we wouldn't have to do it all at once.
> I don't see how we can do that, without some methodical procedure.

Incrementally? I say it might be worth a try, as long as it doesn't go
the GCPRO route. If it does, let's delete it again.

> > But usually there will already be a comment in those functions
> > explaining that they must not call GC, right?
> No, I think these are rare exceptions rather than the rule.

So we can cover these rare exceptions, at least, converting an
ambiguous and hard-to-grep comment into an unambiguous macro
invocation? I don't really see the cons, though it's not as great as
automatic tagging of functions would be...

Pip