[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: master d582356: * src/fns.c (Frandom): Handle bignum `limit`s
From: |
Eli Zaretskii |
Subject: |
Re: master d582356: * src/fns.c (Frandom): Handle bignum `limit`s |
Date: |
Sun, 07 Mar 2021 19:47:29 +0200 |
> From: Pip Cet <pipcet@gmail.com>
> Date: Sun, 7 Mar 2021 17:23:04 +0000
> Cc: Stefan Monnier <monnier@iro.umontreal.ca>, emacs-devel@gnu.org
>
> > > > How do you know which functions to tag?
> > >
> > > That's the part I wasn't volunteering for :-) We'd have to do that
> > > manually, but we wouldn't have to do it all at once.
> > I don't see how we can do that, without some methodical procedure.
>
> Incrementally?
What does this mean in practice, though? Do you try tagging one
function after another, or do you have some guidelines which ones to
tag and which not to tag?
> > > But usually there will already be a comment in those functions
> > > explaining that they must not call GC, right?
> > No, I think these are rare exceptions rather than the rule.
>
> So we can cover these rare exceptions, at least, converting an
> ambiguous and hard-to-grep comment into an unambiguous macro
> invocation? I don't really see the cons, though it's not as great as
> automatic tagging of functions would be...
Maybe there are no cons, but there are also no pro's: covering a small
fraction of the problem means the problem is still with us.
- Re: master d582356: * src/fns.c (Frandom): Handle bignum `limit`s, (continued)
- Re: master d582356: * src/fns.c (Frandom): Handle bignum `limit`s, Eli Zaretskii, 2021/03/06
- Re: master d582356: * src/fns.c (Frandom): Handle bignum `limit`s, Pip Cet, 2021/03/06
- Re: master d582356: * src/fns.c (Frandom): Handle bignum `limit`s, Eli Zaretskii, 2021/03/06
- Re: master d582356: * src/fns.c (Frandom): Handle bignum `limit`s, Pip Cet, 2021/03/06
- Re: master d582356: * src/fns.c (Frandom): Handle bignum `limit`s, Eli Zaretskii, 2021/03/06
- Re: master d582356: * src/fns.c (Frandom): Handle bignum `limit`s, Pip Cet, 2021/03/07
- Re: master d582356: * src/fns.c (Frandom): Handle bignum `limit`s, Eli Zaretskii, 2021/03/07
- Re: master d582356: * src/fns.c (Frandom): Handle bignum `limit`s, Pip Cet, 2021/03/07
- Re: master d582356: * src/fns.c (Frandom): Handle bignum `limit`s, Eli Zaretskii, 2021/03/07
- Re: master d582356: * src/fns.c (Frandom): Handle bignum `limit`s, Pip Cet, 2021/03/07
- Re: master d582356: * src/fns.c (Frandom): Handle bignum `limit`s,
Eli Zaretskii <=
- Re: master d582356: * src/fns.c (Frandom): Handle bignum `limit`s, Stefan Monnier, 2021/03/07
- Re: master d582356: * src/fns.c (Frandom): Handle bignum `limit`s, Andrea Corallo, 2021/03/07
- Re: master d582356: * src/fns.c (Frandom): Handle bignum `limit`s, Pip Cet, 2021/03/07