Re: master a6a5d6a: Move 'revert-buffer' global binding to 'C-x g g'

[Stefan Kangas]

larsi@gnus.org (Lars Ingebrigtsen) writes:

> branch: master
> commit a6a5d6a27a86396ab96662fa158cdcc854bd777b
> Author: Sean Whitton <spwhitton@spwhitton.name>
> Commit: Lars Ingebrigtsen <larsi@gnus.org>
>
>     Move 'revert-buffer' global binding to 'C-x g g'
>
>     * lisp/bindings.el: Define ctl-x-g-map and bind 'revert-buffer' to
>     'C-x x g' globally.
>     * doc/emacs/files.texi: Replace 'C-x g' with 'C-x x g'.
>     * etc/NEWS: Document the change (bug#46300).

One drawback of this change is that messages such as the one you get
here are less obvious:

  M-: (ask-user-about-supersession-threat "foo") RET
  C-h

The help text now says:

    Usually, you should type ‘n’ and then ‘C-x x g’,
    to get the latest version of the file, then make the change again.

The "C-x x g" part used to be "M-x revert-buffer" and therefore more
self-explanatory.  (This is due to subsitute-command-keys replacing the
"\\[revert-buffer]" with the new keybinding.)

So perhaps this change should be accompanied with grepping our sources
for "\\[revert-buffer]" and looking over the relevant substitutions to
make sure the help is sufficiently clear?  I see 16 such matches.