[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: master 80e2647: * lisp/filesets.el: Use lexical-binding
From: |
Lars Ingebrigtsen |
Subject: |
Re: master 80e2647: * lisp/filesets.el: Use lexical-binding |
Date: |
Fri, 12 Mar 2021 17:23:03 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
monnier@iro.umontreal.ca (Stefan Monnier) writes:
> * lisp/filesets.el: Use lexical-binding
A new warning popped up recently (I think) -- but this patch is almost
two months old, so I'm not sure it's relevant or not. Anyway:
In filesets-cmd-isearch-getargs:
filesets.el:1627:17: Warning: global/dynamic var `files' lacks a prefix
And indeed:
(defun filesets-cmd-isearch-getargs ()
"Get arguments for `multi-isearch-files' and `multi-isearch-files-regexp'."
(and (boundp 'files) (list files)))
Now, filesets.el is a twisty maze of functions, but this seems to be
called via the `filesets-commands' alist, and `filesets-cmd-get-def'
which is called from `filesets-cmd-get-fn', which is called from
`filesets-run-cmd'. Which binds `files' lexically, but is probably what
`filesets-cmd-isearch-getargs' is trying to access?
I'm not really confident about that analysis, though...
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
- Re: master 80e2647: * lisp/filesets.el: Use lexical-binding,
Lars Ingebrigtsen <=