[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: master 050b830 3/3: Do interactive mode tagging for finder.el
From: |
Eli Zaretskii |
Subject: |
Re: master 050b830 3/3: Do interactive mode tagging for finder.el |
Date: |
Fri, 19 Mar 2021 10:37:09 +0200 |
> From: Lars Ingebrigtsen <larsi@gnus.org>
> Cc: Stefan Kangas <stefan@marxist.se>, emacs-devel@gnu.org
> Date: Fri, 19 Mar 2021 09:28:16 +0100
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> > I think this part is dangerous: mouse commands are not necessarily
> > issued with the buffer on which they operate being current, so
> > conditioning such commands on the mode of the current buffer is
> > ill-advised.
>
> It's a command that is applicable only to finder-mode buffers, so I
> think the tagging is correct?
It depends on what we do with the tag.
"Applicable only to finder-mode buffers" doesn't tell how we use this
information. We use it to filter out commands as irrelevant in
certain contexts. But this command _is_ relevant even when the major
mode of the current buffer is something other than finder-mode,
because the user can click on text in a non-selected window.
- Re: master 050b830 3/3: Do interactive mode tagging for finder.el, Eli Zaretskii, 2021/03/19
- Re: master 050b830 3/3: Do interactive mode tagging for finder.el, Lars Ingebrigtsen, 2021/03/19
- Re: master 050b830 3/3: Do interactive mode tagging for finder.el,
Eli Zaretskii <=
- Re: master 050b830 3/3: Do interactive mode tagging for finder.el, Stefan Kangas, 2021/03/19
- Re: master 050b830 3/3: Do interactive mode tagging for finder.el, Eli Zaretskii, 2021/03/19
- Re: master 050b830 3/3: Do interactive mode tagging for finder.el, Stefan Kangas, 2021/03/19
- Re: master 050b830 3/3: Do interactive mode tagging for finder.el, Eli Zaretskii, 2021/03/19
- RE: [External] : Re: master 050b830 3/3: Do interactive mode tagging for finder.el, Drew Adams, 2021/03/19
- Re: master 050b830 3/3: Do interactive mode tagging for finder.el, Lars Ingebrigtsen, 2021/03/20
- Re: master 050b830 3/3: Do interactive mode tagging for finder.el, Lars Ingebrigtsen, 2021/03/20
- Re: master 050b830 3/3: Do interactive mode tagging for finder.el, Eli Zaretskii, 2021/03/20
- Re: master 050b830 3/3: Do interactive mode tagging for finder.el, Lars Ingebrigtsen, 2021/03/20
- Re: master 050b830 3/3: Do interactive mode tagging for finder.el, Eli Zaretskii, 2021/03/20