Re: master 432c1aa: Use `pop-to-buffer-same-window' in `project-eshell'

[Stefan Kangas]

simenheg@gmail.com (Simen Heggestøyl) writes:

> branch: master
> commit 432c1aaa80ce109250a93f50858a03ce3d01ca34
> Author: Simen Heggestøyl <simenheg@gmail.com>
> Commit: Simen Heggestøyl <simenheg@runbox.com>
>
>     Use `pop-to-buffer-same-window' in `project-eshell'
>
>     * lisp/progmodes/project.el (project-eshell): Use
>     `pop-to-buffer-same-window' instead of `pop-to-buffer' to match the
>     behavior of `M-x eshell'.

I'm fine with this change.  (I've personally started using
`other-window-prefix' to open eshell in another window, which is what I
almost always want here.)

But now `project-eshell' and `project-shell' behave differently, which
seems unfortunate.  So if this is the behavior we want, shouldn't we
change the latter as well for consistency?

(OTOH, I checked the `projectile' package, and it seems to be exhibiting
the same difference in behavior between shell and eshell...)