emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: modus-themes ELPA and etc/themes


From: Stefan Monnier
Subject: Re: modus-themes ELPA and etc/themes
Date: Sat, 20 Mar 2021 16:39:31 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)

>> The problem is due to the fact that the file is under `etc/themes` and
>> is hence not processed by our autoloads machinery which would otherwise
>> add something like
>> 
>>     (push (purecopy '(modus-themes 1 2 4)) package--builtin-versions)
>> 
>> to lisp/loaddefs.el.
>> 
>> There are various ways to fix this, but to me the simplest would be to
>> move `etc/themes` to `lisp` (or at least to move `modus-themes.el`).
>
> I'd rather we didn't move files around.  If nothing else, it makes
> forensics harder down the line.  Besides, we had themes in that place
> for too long to make such changes now, and for this minor reason on
> top of that.

OK, so it's a definite no for moving `etc/themes`.

How 'bout moving just `modus-themes.el` (it's a fresh new file, so the
forensics aspect shouldn't matter that much, especially since the real
Git history is in the upstream repository rather than in emacs.git
anyway)?  Part of the reason why `modus-themes.el` could be treated
differently is that it actually contains a fair bit of ELisp code, so it
would make sense to compile it.

> Why can't we take any of the other ways to fix this?

Oh, we definitely can, I'm just trying to figure out which solution is best.


        Stefan




reply via email to

[Prev in Thread] Current Thread [Next in Thread]