RE: [External] : Re: PR: dired-do-create-files now checks for trailing slashes in the target

[Drew Adams]

> >>   file -> 2.txt (renames plain file no matter if 2.txt already
> >>                  exists)
> >>   file -> foo   (move into foo if that's an existing dir, otherwise
> >>                  rename)
> >>   file -> foo/  (move into directory foo, creating if not existing
> >>                  and dired-create-destination-dirs is non-nil)
> >>
> >> The first 2 are unchanged, the third one is the new one.
> >
> > What about:  foo -> foo/
> >
> > Does that move file foo to directory foo, as
> > foo/foo, creating directory foo if it doesn't
> > exist?
> 
> No, it errors in the same way as it does without the patch.

OK, good.

>   Move: ‘/home/horn/tmp/foo’ to ‘/home/horn/tmp/foo/foo’ failed:
>   (file-error Renaming Invalid argument /home/horn/tmp/foo
> /home/horn/tmp/foo/foo)

That error msg isn't so great, FWIW.  This is
a design choice.  What's the invalid argument
(which)?  It could at least say that the dir
to move to doesn't exist.

The doc should at least call this case out
where it talks about this (optional) feature
of an appended `/' creating a missing dir.