emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] PGTK patches


From: Yuuki Harano
Subject: Re: [PATCH] PGTK patches
Date: Sun, 14 Nov 2021 22:42:33 +0900 (JST)

Thanks.

On Sun, 14 Nov 2021 23:34:51 +1100,
        Fejfighter <fejfighter@gmail.com> wrote:
> -  if (!FRAME_GTK_OUTER_WIDGET (f))
> +  if (!FRAME_GTK_OUTER_WIDGET (f)) {
> +    if (FRAME_WIDGET(f))
> +     gtk_widget_set_can_focus(FRAME_WIDGET(f), g_no_accept_focus);
>      return;
> +  }

Please fix coding style.
- position of braces
- insert a space between function/macro name and open-paren.

> +           gtk_widget_grab_focus(FRAME_GTK_WIDGET(f));
> +           if (FRAME_GTK_OUTER_WIDGET(f))
> +             gtk_window_present(GTK_WINDOW(FRAME_GTK_OUTER_WIDGET(f)));

Here, too.

-- 
Yuuki Harano



reply via email to

[Prev in Thread] Current Thread [Next in Thread]