emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] PGTK patches


From: Po Lu
Subject: Re: [PATCH] PGTK patches
Date: Mon, 15 Nov 2021 13:25:37 +0800
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.60 (gnu/linux)

Fejfighter <fejfighter@gmail.com> writes:

> +           gtk_widget_grab_focus(FRAME_GTK_WIDGET(f));
> +           if (FRAME_GTK_OUTER_WIDGET(f))

These two lines are redundant.  If a button event is received, there has
to be an outer widget, and gtk_widget_grab_focus only sets the
GtkWindow's input focus, which shouldn't be necessary because
FRAME_GTK_WIDGET is the default widget.

> +             gtk_window_present(GTK_WINDOW(FRAME_GTK_OUTER_WIDGET(f)));

This by itself should be enough.  Thanks.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]