Re: GStreamer xwidget

[Lars Ingebrigtsen]

Po Lu <luangruo@yahoo.com> writes:

> Right now, it can only display a test pattern, but getting that to work
> and perform decently was a challenge (for instance, offscreen rendering
> is not an option,

Hm...  isn't the webkit rendering done offscreen?  And that's able to
play videos just fine?

> instead the pipeline is dynamically built based on
> available xwidget views, utilizing hardware acceleration and video
> decoding if available).
>
> WDYT?

Sounds good to me.

Do you have a code snippet that will display one of these widgets?  Then
I can test the patch here.

Skimming the patch, it looks good to me.  The one extremely minor nit I
have is this superfluous {}:

> +#ifdef HAVE_GSTREAMER
> +           if (EQ (xw->type, Qmedia))
> +             {
> +               XResizeWindow (xv->dpy, xv->internal_window,
> +                              xw->width, xw->height);
> +             }

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no