[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: browse-url-interactive-arg calls `mouse-set-point' too eagerly
From: |
Eli Zaretskii |
Subject: |
Re: browse-url-interactive-arg calls `mouse-set-point' too eagerly |
Date: |
Sat, 20 Nov 2021 09:31:12 +0200 |
> From: Po Lu <luangruo@yahoo.com>
> Date: Sat, 20 Nov 2021 14:29:49 +0800
>
> The doc string of browse-url-interactive-arg says:
>
> If invoked with a mouse button, it moves point to the position clicked
> before acting.
>
> But the code treats any event that is a list as a mouse event, which
> fails horribly with menu bar events.
>
> So why not replace the faulty code with something like:
>
> (let ((event (elt (this-command-keys) 0)))
> (when (mouse-event-p event)
> (mouse-set-point event)))
>
> WDYT?
SGTM, thanks. Please do this on the emacs-28 branch, as I believe the
same problem exists there.