Re: Correct byte compiler error/warning positions. The solution!

[Alan Mackenzie]

Hello, Eli.

On Sun, Nov 28, 2021 at 09:25:03 +0200, Eli Zaretskii wrote:
> > Date: Sat, 27 Nov 2021 23:05:12 +0000
> > Cc: emacs-devel@gnu.org
> > From: Alan Mackenzie <acm@muc.de>

> > The timings I have for scrolling in the forward direction (each time
> > preceded by M-x garbage-collect, and typing/erasing a character to clear
> > the font-lock settings) are:

> > (master branch, no native compilation):
> > 20.847s, 21.609s, 19.459s, 21.570s, 21.651

> > (New code with correct warning messages, no native compilation):
> > 21.284s, 42.152s ????, 19.927s, 19.960s, 22.259s, 22.198, 22.209s.

> > The input to configure was the same in both cases, namely

> >   ./configure --with-gif=no --with-tiff=no --with-gpm.

> > , and the timings were done on the Linux console.

> > No, I don't understand that 42s run.  A lot of garbage collection,
> > perhaps?

> You should always record the time take by GC and subtract it from the
> elapsed time.  I believe benchmark-run shows that time, so please use
> it in the comparison.

OK, I've done that a few times, thanks.  There were 97 GCs in a run,
totalling around 5 seconds.  I'll try it more systematically some time.

I've become a little confused over the "==" in lisp_h_NILP that we were
discussing.  Omitting the XLI calls causes GCC 10.3.0 to build a smaller
executable.  (This was with debugging info switched off.)  I realise this
is not acceptable, since there are other systems this wouldn't compile
under.

Anyhow, I've committed the current state in the new branch
scratch/correct-warning-pos.  It should build and run OK, although I
haven't tried it out with native compilation, yet.  It is marginally
slower than master.  Maybe we can merge it into master some time for
Emacs 29.

-- 
Alan Mackenzie (Nuremberg, Germany).