Re: Correct byte compiler error/warning positions. The solution!

[Robert Pluim]

>>>>> On Mon, 29 Nov 2021 11:50:19 +0000, Alan Mackenzie <acm@muc.de> said:
    Alan> Anyhow, I've committed the current state in the new branch
    Alan> scratch/correct-warning-pos.  It should build and run OK, although I
    Alan> haven't tried it out with native compilation, yet.  It is marginally
    Alan> slower than master.  Maybe we can merge it into master some time for
    Alan> Emacs 29.

"Thou shalt listen to Eli's warnings about '==', else your branch
shall not compile"

./configure --enable-check-lisp-object-type --enable-checking

make[1]: Entering directory '/home/rpluim/repos/emacs-pos/src'
  CC       dispnew.o
In file included from dispnew.c:27:
lisp.h: In function ‘EQ’:
lisp.h:385:40: error: invalid operands to binary == (have ‘Lisp_Object’ and 
‘Lisp_Object’)
  385 |         ? (XSYMBOL_WITH_POS((x)))->sym == (y)          \
      |           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^~
      |                                  |
      |                                  Lisp_Object
lisp.h:1329:10: note: in expansion of macro ‘lisp_h_EQ’
 1329 |   return lisp_h_EQ (x, y);
      |          ^~~~~~~~~
lisp.h:388:15: error: invalid operands to binary == (have ‘Lisp_Object’ and 
‘Lisp_Object’)
  387 |           && ((XSYMBOL_WITH_POS((x)))->sym                   \
      |               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |                                      |
      |                                      Lisp_Object
  388 |               == (XSYMBOL_WITH_POS((y)))->sym)               \
      |               ^~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |                                         |
      |                                         Lisp_Object
lisp.h:1329:10: note: in expansion of macro ‘lisp_h_EQ’
 1329 |   return lisp_h_EQ (x, y);
      |          ^~~~~~~~~
lisp.h:391:18: error: invalid operands to binary == (have ‘Lisp_Object’ and 
‘Lisp_Object’)
  391 |          && ((x) == ((XSYMBOL_WITH_POS ((y)))->sym))))))
      |                  ^~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |                                              |
      |                                              Lisp_Object
lisp.h:1329:10: note: in expansion of macro ‘lisp_h_EQ’
 1329 |   return lisp_h_EQ (x, y);
      |          ^~~~~~~~~
In file included from dispnew.c:27:
lisp.h:1330:1: warning: control reaches end of non-void function [-Wreturn-type]
 1330 | }
      | ^
make[1]: *** [Makefile:406: dispnew.o] Error 1

Robert
--