[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: master 18b680cfd1: Fix bug#52467 by adding a new custom variable 'di
From: |
jakanakaevangeli |
Subject: |
Re: master 18b680cfd1: Fix bug#52467 by adding a new custom variable 'display-comint-buffer-action' |
Date: |
Tue, 28 Dec 2021 23:59:13 +0100 |
Dmitry Gutov <dgutov@yandex.ru> writes:
> Hi Sam,
>
> On 29.12.2021 01:30, Sam Steingold wrote:
>> diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el
>> index 3b634471ac..62dba7b393 100644
>> --- a/lisp/progmodes/project.el
>> +++ b/lisp/progmodes/project.el
>> @@ -1015,7 +1015,7 @@ if one already exists."
>> (default-project-shell-name (project-prefixed-buffer-name
>> "shell"))
>> (shell-buffer (get-buffer default-project-shell-name)))
>> (if (and shell-buffer (not current-prefix-arg))
>> - (pop-to-buffer-same-window shell-buffer)
>> + (pop-to-buffer shell-buffer display-comint-buffer-action)
>> (shell (generate-new-buffer-name default-project-shell-name)))))
>>
>> ;;;###autoload
>> @@ -1031,7 +1031,7 @@ if one already exists."
>> (eshell-buffer-name (project-prefixed-buffer-name "eshell"))
>> (eshell-buffer (get-buffer eshell-buffer-name)))
>> (if (and eshell-buffer (not current-prefix-arg))
>> - (pop-to-buffer-same-window eshell-buffer)
>> + (pop-to-buffer eshell-buffer display-comint-buffer-action)
>
> Please add boundp fallbacks: project.el should retain compatibility with
> older Emacs releases.
Also here:
> diff --git a/lisp/shell.el b/lisp/shell.el
> index 370532ea46..1860e4691d 100644
> --- a/lisp/shell.el
> +++ b/lisp/shell.el
> @@ -758,7 +758,7 @@ shell
> (current-buffer)))
> ;; The buffer's window must be correctly set when we call comint
> ;; (so that comint sets the COLUMNS env var properly).
> - (pop-to-buffer-same-window buffer)
> + (pop-to-buffer buffer)
>
> (with-connection-local-variables
> ;; On remote hosts, the local `shell-file-name' might be useless.
should probably be
(pop-to-buffer buffer display-comint-buffer-action)
to make it analogous to the other changes in the patch.
- Re: master 18b680cfd1: Fix bug#52467 by adding a new custom variable 'display-comint-buffer-action', Dmitry Gutov, 2021/12/28
- Re: master 18b680cfd1: Fix bug#52467 by adding a new custom variable 'display-comint-buffer-action', Lars Ingebrigtsen, 2021/12/29
- Re: master 18b680cfd1: Fix bug#52467 by adding a new custom variable 'display-comint-buffer-action', Eli Zaretskii, 2021/12/29
- Re: master 18b680cfd1: Fix bug#52467 by adding a new custom variable 'display-comint-buffer-action', martin rudalics, 2021/12/30
- Re: master 18b680cfd1: Fix bug#52467 by adding a new custom variable 'display-comint-buffer-action', martin rudalics, 2021/12/30
- Re: master 18b680cfd1: Fix bug#52467 by adding a new custom variable 'display-comint-buffer-action', martin rudalics, 2021/12/30
- Re: master 18b680cfd1: Fix bug#52467 by adding a new custom variable 'display-comint-buffer-action', Stefan Monnier, 2021/12/30
- Re: master 18b680cfd1: Fix bug#52467 by adding a new custom variable 'display-comint-buffer-action', martin rudalics, 2021/12/30
- Re: master 18b680cfd1: Fix bug#52467 by adding a new custom variable 'display-comint-buffer-action', Lars Ingebrigtsen, 2021/12/30
- Re: master 18b680cfd1: Fix bug#52467 by adding a new custom variable 'display-comint-buffer-action', martin rudalics, 2021/12/30