Re: master 02bca34: Utilize new string decoding feature in GTK native input

[Po Lu]

Eli Zaretskii <eliz@gnu.org> writes:

> Is this a good idea?  Consing a string when we process input increases
> GC pressure, and what issues does this change solve as a
> counter-weight for that disadvantage?  Is g_utf8_to_ucs4 a problematic
> API or something?

No, but some input method modules don't always return valid UTF-8 like
they're supposed to, thereby causing crashes in g_utf8_to_ucs4_fast.

I should have explained that in the commit message.

> But in general, decoding UTF-8 encoded C string is better done without
> consing a string and then using the coding.c stuff.  After all, if the
> original string is 100% guaranteed to be in UTF-8, the decoding is
> almost trivial.

It's supposedly guaranteed, but some input method modules break that
guarantee.

Thanks.