[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: master 02bca34: Utilize new string decoding feature in GTK native in
From: |
Po Lu |
Subject: |
Re: master 02bca34: Utilize new string decoding feature in GTK native input |
Date: |
Sat, 19 Feb 2022 20:49:58 +0800 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) |
Eli Zaretskii <eliz@gnu.org> writes:
> You can still explain that in a comment to the code.
Thanks, will do.
> And what do we want to do with those invalid UTF-8 sequences? The way
> you did it will produce raw bytes for them -- is that really TRT in
> this case?
Yes, it'll alert the user that something has gone wrong with the input
method.
> In any case, at the very least consider using decode_string_utf_8
> instead of consing a Lisp string and then using the "usual" decoding
> stuff -- decode_string_utf_8 will cons only one string.
I will look into that.