emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: master 30dbdecd4a: * src/xterm.c: Add a small writeup on input handl


From: Po Lu
Subject: Re: master 30dbdecd4a: * src/xterm.c: Add a small writeup on input handling on X.
Date: Tue, 01 Mar 2022 08:40:13 +0800
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux)

martin rudalics <rudalics@gmx.at> writes:

> While we're there: If I'm not mistaken, xg_frame_set_char_size now has
> three instances of
>
> #ifndef HAVE_PGTK
>       gtk_window_resize (GTK_WINDOW (FRAME_GTK_OUTER_WIDGET (f)),
>                        outer_width, outer_height);
> #else
>       if (FRAME_GTK_OUTER_WIDGET (f))
>       {
>         gtk_window_resize (GTK_WINDOW (FRAME_GTK_OUTER_WIDGET (f)),
>                            outer_width, outer_height);
>       }
>       else
>       {
>         gtk_widget_set_size_request (FRAME_GTK_WIDGET (f),
>                                      outer_width, outer_height);
>       }
> #endif
>
> Could you please refactor these into a separate routine and/or at least
> remove those extra braces.

I'm not sure what those are for, but I will look into that.

Thanks.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]