[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: master 5141234acf: Refactor the webp cache code to allow usage by gi
From: |
Lars Ingebrigtsen |
Subject: |
Re: master 5141234acf: Refactor the webp cache code to allow usage by gif_load, too |
Date: |
Mon, 11 Apr 2022 14:44:23 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) |
Po Lu <luangruo@yahoo.com> writes:
> Shouldn't this be formatted like:
>
> void (*destructor) (void *);
>
> instead?
Yup.
>> + cache->spec = spec;
>
> I think this should be marked, since I don't see what protects the spec
> from garbage collection otherwise.
I suspect so, but as the comment on the previous line says, I wasn't
quite sure. We're only using it to test for EQ-ness... but I guess
that will break if we're using the complex Lisp object type.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
- Re: master 5141234acf: Refactor the webp cache code to allow usage by gif_load, too, Po Lu, 2022/04/11
- Re: master 5141234acf: Refactor the webp cache code to allow usage by gif_load, too,
Lars Ingebrigtsen <=
- Re: master 5141234acf: Refactor the webp cache code to allow usage by gif_load, too, Po Lu, 2022/04/11
- Re: master 5141234acf: Refactor the webp cache code to allow usage by gif_load, too, Lars Ingebrigtsen, 2022/04/11
- Re: master 5141234acf: Refactor the webp cache code to allow usage by gif_load, too, Po Lu, 2022/04/11
- Re: master 5141234acf: Refactor the webp cache code to allow usage by gif_load, too, Lars Ingebrigtsen, 2022/04/11
- Re: master 5141234acf: Refactor the webp cache code to allow usage by gif_load, too, Po Lu, 2022/04/11
- Re: master 5141234acf: Refactor the webp cache code to allow usage by gif_load, too, Stefan Monnier, 2022/04/11
- Re: master 5141234acf: Refactor the webp cache code to allow usage by gif_load, too, Lars Ingebrigtsen, 2022/04/11
Re: master 5141234acf: Refactor the webp cache code to allow usage by gif_load, too, Eli Zaretskii, 2022/04/11