Re: Emacs 28 on OSX: emacsclient.c:1415: warning: implicit declaration of function 'openat'

[Keith David Bershatsky]

The latest patch from Alan applied without issue, but there is still something 
that stops the build at nsmenu.m

  CC       nsfns.o
In file included from nsfns.m:36:
lisp.h:2156: warning: declaration does not declare anything
nsfns.m:1099: warning: braces around scalar initializer
nsfns.m:1099: warning: (near initialization for 
'Sx_create_frame.s.command_modes')
nsfns.m:1528: warning: braces around scalar initializer
nsfns.m:1528: warning: (near initialization for 
'Sns_frame_list_z_order.s.command_modes')
nsfns.m:1559: warning: braces around scalar initializer
nsfns.m:1559: warning: (near initialization for 
'Sns_frame_restack.s.command_modes')
nsfns.m:1590: warning: braces around scalar initializer
nsfns.m:1590: warning: (near initialization for 
'Sns_popup_font_panel.s.command_modes')
nsfns.m:1590: warning: initialization from incompatible pointer type
nsfns.m:1611: warning: braces around scalar initializer
nsfns.m:1611: warning: (near initialization for 
'Sns_popup_color_panel.s.command_modes')
nsfns.m:1611: warning: initialization from incompatible pointer type
nsfns.m:1664: warning: braces around scalar initializer
nsfns.m:1664: warning: (near initialization for 
'Sns_read_file_name.s.command_modes')
nsfns.m:1782: warning: braces around scalar initializer
nsfns.m:1782: warning: (near initialization for 
'Sns_get_resource.s.command_modes')
nsfns.m:1802: warning: braces around scalar initializer
nsfns.m:1802: warning: (near initialization for 
'Sns_set_resource.s.command_modes')
nsfns.m:1829: warning: braces around scalar initializer
nsfns.m:1829: warning: (near initialization for 
'Sx_server_max_request_size.s.command_modes')
nsfns.m:1842: warning: braces around scalar initializer
nsfns.m:1842: warning: (near initialization for 
'Sx_server_vendor.s.command_modes')
nsfns.m:1855: warning: braces around scalar initializer
nsfns.m:1855: warning: (near initialization for 
'Sx_server_version.s.command_modes')
nsfns.m:1870: warning: braces around scalar initializer
nsfns.m:1870: warning: (near initialization for 
'Sx_display_screens.s.command_modes')
nsfns.m:1879: warning: braces around scalar initializer
nsfns.m:1879: warning: (near initialization for 
'Sx_display_mm_height.s.command_modes')
nsfns.m:1889: warning: braces around scalar initializer
nsfns.m:1889: warning: (near initialization for 
'Sx_display_mm_width.s.command_modes')
nsfns.m:1899: warning: braces around scalar initializer
nsfns.m:1899: warning: (near initialization for 
'Sx_display_backing_store.s.command_modes')
nsfns.m:1923: warning: braces around scalar initializer
nsfns.m:1923: warning: (near initialization for 
'Sx_display_visual_class.s.command_modes')
nsfns.m:1950: warning: braces around scalar initializer
nsfns.m:1950: warning: (near initialization for 
'Sx_display_save_under.s.command_modes')
nsfns.m:1974: warning: braces around scalar initializer
nsfns.m:1974: warning: (near initialization for 
'Sx_open_connection.s.command_modes')
nsfns.m:1999: warning: braces around scalar initializer
nsfns.m:1999: warning: (near initialization for 
'Sx_close_connection.s.command_modes')
nsfns.m:2010: warning: braces around scalar initializer
nsfns.m:2010: warning: (near initialization for 
'Sx_display_list.s.command_modes')
nsfns.m:2024: warning: braces around scalar initializer
nsfns.m:2024: warning: (near initialization for 
'Sns_hide_others.s.command_modes')
nsfns.m:2034: warning: braces around scalar initializer
nsfns.m:2034: warning: (near initialization for 
'Sns_hide_emacs.s.command_modes')
nsfns.m:2067: warning: braces around scalar initializer
nsfns.m:2067: warning: (near initialization for 
'Sns_emacs_info_panel.s.command_modes')
nsfns.m:2078: warning: braces around scalar initializer
nsfns.m:2078: warning: (near initialization for 'Sns_font_name.s.command_modes')
nsfns.m:2098: warning: braces around scalar initializer
nsfns.m:2098: warning: (near initialization for 
'Sns_list_colors.s.command_modes')
nsfns.m:2138: warning: braces around scalar initializer
nsfns.m:2138: warning: (near initialization for 
'Sns_list_services.s.command_modes')
nsfns.m:2163: warning: braces around scalar initializer
nsfns.m:2163: warning: (near initialization for 
'Sns_perform_service.s.command_modes')
nsfns.m:2261: warning: braces around scalar initializer
nsfns.m:2261: warning: (near initialization for 
'Sns_do_applescript.s.command_modes')
nsfns.m:2419: warning: braces around scalar initializer
nsfns.m:2419: warning: (near initialization for 
'Sxw_color_defined_p.s.command_modes')
nsfns.m:2429: warning: braces around scalar initializer
nsfns.m:2429: warning: (near initialization for 
'Sxw_color_values.s.command_modes')
nsfns.m:2454: warning: braces around scalar initializer
nsfns.m:2454: warning: (near initialization for 
'Sxw_display_color_p.s.command_modes')
nsfns.m:2471: warning: braces around scalar initializer
nsfns.m:2471: warning: (near initialization for 
'Sx_display_grayscale_p.s.command_modes')
nsfns.m:2485: warning: braces around scalar initializer
nsfns.m:2485: warning: (near initialization for 
'Sx_display_pixel_width.s.command_modes')
nsfns.m:2496: warning: braces around scalar initializer
nsfns.m:2496: warning: (near initialization for 
'Sx_display_pixel_height.s.command_modes')
nsfns.m:2637: warning: braces around scalar initializer
nsfns.m:2637: warning: (near initialization for 
'Sns_display_monitor_attributes_list.s.command_modes')
nsfns.m:2741: warning: braces around scalar initializer
nsfns.m:2741: warning: (near initialization for 
'Sx_display_planes.s.command_modes')
nsfns.m:2752: warning: braces around scalar initializer
nsfns.m:2752: warning: (near initialization for 
'Sx_display_color_cells.s.command_modes')
nsfns.m:2841: warning: braces around scalar initializer
nsfns.m:2841: warning: (near initialization for 'Sx_show_tip.s.command_modes')
nsfns.m:2904: warning: braces around scalar initializer
nsfns.m:2904: warning: (near initialization for 'Sx_hide_tip.s.command_modes')
nsfns.m:2981: warning: braces around scalar initializer
nsfns.m:2981: warning: (near initialization for 
'Sns_frame_geometry.s.command_modes')
nsfns.m:3025: warning: braces around scalar initializer
nsfns.m:3025: warning: (near initialization for 
'Sns_frame_edges.s.command_modes')
nsfns.m:3049: warning: braces around scalar initializer
nsfns.m:3049: warning: (near initialization for 
'Sns_set_mouse_absolute_pixel_position.s.command_modes')
nsfns.m:3091: warning: braces around scalar initializer
nsfns.m:3091: warning: (near initialization for 
'Sns_mouse_absolute_pixel_position.s.command_modes')
nsfns.m:3110: warning: braces around scalar initializer
nsfns.m:3110: warning: (near initialization for 
'Sns_show_character_palette.s.command_modes')
  CC       nsmenu.o
In file included from nsmenu.m:28:
lisp.h:2156: warning: declaration does not declare anything
nsmenu.m: In function '-[EmacsMenu fillWithWidgetValue:]':
nsmenu.m:679: error: 'NSTextAlignmentRight' undeclared (first use in this 
function)
nsmenu.m:679: error: (Each undeclared identifier is reported only once
nsmenu.m:679: error: for each function it appears in.)
nsmenu.m: At top level:
nsmenu.m:1942: warning: braces around scalar initializer
nsmenu.m:1942: warning: (near initialization for 
'Sns_reset_menu.s.command_modes')
nsmenu.m:1951: warning: braces around scalar initializer
nsmenu.m:1951: warning: (near initialization for 
'Smenu_or_popup_active_p.s.command_modes')
make[1]: *** [nsmenu.o] Error 1
make: *** [src] Error 2
~/Desktop/emacs $ git apply 
/Users/HOME/Desktop/0001-Fix-nsmenu-compilation-under-macOS-10.6.patch

;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;

> Date: [04-18-2022 21:19:10] <19 Apr 2022 05:19:10 +0100>
> From: Alan Third <alan@idiocy.org>
> To: Po Lu <luangruo@yahoo.com>
> Cc: Keith David Bershatsky <esq@lawlist.com>, emacs-devel@gnu.org, Mattias 
> Engdegård <mattiase@acm.org>, Paul Eggert <eggert@cs.ucla.edu>
> Subject: Re: Emacs 28 on OSX: emacsclient.c:1415: warning: implicit 
> declaration of function 'openat'