Re: master 4fb028be6c 3/3: Fix releasing the mouse on top of the tool bar on MS Windows

[Eli Zaretskii]

> branch: master
> commit 4fb028be6c2de5a556f56bb40a3f948a143cef37
> Author: Po Lu <luangruo@yahoo.com>
> Commit: Po Lu <luangruo@yahoo.com>
> 
>     Fix releasing the mouse on top of the tool bar on MS Windows
>     
>     * src/w32term.c (w32_read_socket): Don't handle tool bar clicks
>     specially for button up events if no tool bar item was
>     previously pressed.
> ---
>  src/w32term.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/src/w32term.c b/src/w32term.c
> index 1937f94645..205ac74966 100644
> --- a/src/w32term.c
> +++ b/src/w32term.c
> @@ -5365,7 +5365,9 @@ w32_read_socket (struct terminal *terminal,
>  
>                      window = window_from_coordinates (f, x, y, 0, 1, 1);
>  
> -                    if (EQ (window, f->tool_bar_window))
> +                    if (EQ (window, f->tool_bar_window)
> +                     && (inev.modifiers & down_modifier
> +                         || f->last_tool_bar_item != -1))
>                        {
>                          w32_handle_tool_bar_click (f, &inev);
>                          tool_bar_p = 1;
> 

Can you tell what was the problem, and how to see it happening before
the change?

Thanks.