emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] eshell-exec-visual: Don't drop existing escape char


From: Sean Whitton
Subject: [PATCH] eshell-exec-visual: Don't drop existing escape char
Date: Mon, 20 Jun 2022 17:35:49 -0700

Since this code was written, `term-set-escape-char' has begun undoing
previous calls to itself.  Additionally, there is nothing in the
documentation for `eshell-escape-control-x' suggesting it is meant to
replace the existing escape char as opposed to adding a second.  See
also comments in `ansi-term'.

* lisp/eshell/em-term.el (eshell-exec-visual): Don't drop existing
escape char.
---
 lisp/eshell/em-term.el | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lisp/eshell/em-term.el b/lisp/eshell/em-term.el
index d150c07b03..6aefb8b599 100644
--- a/lisp/eshell/em-term.el
+++ b/lisp/eshell/em-term.el
@@ -187,7 +187,8 @@ eshell-exec-visual
          (error "Failed to invoke visual command")))
       (term-char-mode)
       (if eshell-escape-control-x
-         (term-set-escape-char ?\C-x))))
+          ;; Don't drop existing escape char.
+          (let (term-escape-char) (term-set-escape-char ?\C-x)))))
   nil)
 
 ;; Process sentinels receive two arguments.
-- 
2.30.2




reply via email to

[Prev in Thread] Current Thread [Next in Thread]