Re: master updated (4b1ab18391 -> 8517d1e9aa)

[Basil L. Contovounesios]

Stefan Kangas [2022-08-17 04:13 -0700] wrote:

> The above seems to lead some warnings that, at a glance, I wasn't
> immediately sure weren't false positives:
>
> In battery-linux-proc-apm:
> battery.el:372:19: Warning: value returned from (logand tem 2) is unused
> battery.el:375:19: Warning: value returned from (logand tem 16) is unused
> battery.el:372:19: Warning: value returned from (logand tem 2) is unused
> battery.el:375:19: Warning: value returned from (logand tem 16) is unused

I took the liberty of fixing these C-isms (falla-Cs?):

Fix Linux APM BIOS flag testing in battery.el
31f289625c 2022-08-17 20:11:25 +0300
https://git.sv.gnu.org/cgit/emacs.git/commit/?id=31f289625c

> In edmacro-sanitize-for-string:
> edmacro.el:629:19: Warning: value returned from (logand (aref seq i)
> 128) is unused
> edmacro.el:629:19: Warning: value returned from (logand (aref seq i)
> 128) is unused

I leave this similar falla-C for someone else.

> In reb-fontify-string-re:
> emacs-lisp/re-builder.el:739:29: Warning: value returned from (memq
> 'font-lock-string-face face) is unused
> emacs-lisp/re-builder.el:739:29: Warning: value returned from (memq
> 'font-lock-string-face face) is unused
> emacs-lisp/re-builder.el:739:29: Warning: value returned from (memq
> 'font-lock-string-face face) is unused

This one's curious: the entire surrounding (or ...) expression always
evals to non-nil.  Lennart?

> In c-enclosing-c++-attribute:
> progmodes/cc-engine.el:1960:37: Warning: value returned from (min (+
> (point) 200) (point-max)) is unused
> progmodes/cc-engine.el:1960:37: Warning: value returned from (min (+
> (point) 200) (point-max)) is unused
>
> In c-get-fontification-context:
> progmodes/cc-fonts.el:1266:43: Warning: value returned from (max (-
> (point) 2000) (point-min)) is unused

I leave these non-falla-CCs for someone else.

Thanks,

-- 
Basil