emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: esh-proc test failures


From: Eli Zaretskii
Subject: Re: esh-proc test failures
Date: Mon, 22 Aug 2022 21:56:43 +0300

> From: Jim Porter <jporterbugs@gmail.com>
> Cc: emacs-devel@gnu.org
> Date: Mon, 22 Aug 2022 10:06:36 -0700
> 
> diff --git a/lisp/eshell/esh-cmd.el b/lisp/eshell/esh-cmd.el
> index 2f77f3f497..d5cc3706fd 100644
> --- a/lisp/eshell/esh-cmd.el
> +++ b/lisp/eshell/esh-cmd.el
> @@ -1347,6 +1347,10 @@ eshell-exec-lisp
>                   (apply func-or-form args)))))
>          (and result (funcall printer result))
>          result)
> +    (eshell-pipe-broken
> +     ;; 141 is 128 + 13 (the numeric value of SIGPIPE).
> +     (setq eshell-last-command-status 141)
> +     nil)

This is non-portable, I think on two counts:

 . the assumption that the exit code is the signal number left-shifted
   by N bits (btw, isn't N = 8, not 7?)
 . the assumption that SIGPIPE is signal 13 (does Posix mandate that?)

What do we expect to happen here on MS-Windows and other non-Posix
platforms, where both of the above assumptions are false?



reply via email to

[Prev in Thread] Current Thread [Next in Thread]