Re: master 4803fba487 1/2: 'C-x v v' on a diff buffer commits it as a patch (bug#52349)

[Eli Zaretskii]

> Date: Tue, 30 Aug 2022 17:38:27 +0300
> Cc: eliz@gnu.org, larsi@gnus.org, juri@jurta.org, emacs-devel@gnu.org
> From: Dmitry Gutov <dgutov@yandex.ru>
> 
> I can look into adapting this approach for other VCS if nobody beats me 
> to it.

Thanks.

>  As long as we fundamentally agree on the behavior.

I think the "C-x v D" step should be part of the command's execution.
It makes little sense to me to ask the user to prepare the diffs in
advance, since conceptually the changes are already on disk.  Starting
from diffs makes sense when you want to apply them first, and only
after that commit.  Which is not the case here.

I understand that typing "C-x v v" in a diffs buffer is used here as
an indication that this particular variant of "committing" is
requested, but that's a weak justification, IMO.  It could even
backfire: the user could be in the diffs by sheer luck (or lack
thereof), and type "C-x v v" without any intention to select parts of
the changes.

I think a special numeric argument (like "C-u 0", perhaps?) is more
appropriate to signal the interactive selection of changes.