Re: [elpa] externals/zuul 785d2d1619 2/6: Add defvar to zuul-log-mode-map

[Stefan Monnier]

This `defvar` needs to come before the `define-derived-mode` otherwise
it'll do nothing.


        Stfean


ELPA Syncer [2022-08-30 15:58:11] wrote:

> branch: externals/zuul
> commit 785d2d1619245023695daa0a1951749b30c00f30
> Author: Niklas Eklund <niklas.eklund@posteo.net>
> Commit: Niklas Eklund <niklas.eklund@posteo.net>
>
>     Add defvar to zuul-log-mode-map
> ---
>  zuul.el | 24 +++++++++++++-----------
>  1 file changed, 13 insertions(+), 11 deletions(-)
>
> diff --git a/zuul.el b/zuul.el
> index b7340dc61c..07f4916daf 100644
> --- a/zuul.el
> +++ b/zuul.el
> @@ -1126,17 +1126,19 @@ Optionally provide extra parameters PARAMS, PARSER, 
> METHOD, BUFFER or HEADERS."
>    (font-lock-mode)
>    (zuul--highlight-cmd))
>  
> -(let ((map zuul-log-mode-map))
> -  (define-key map (kbd "C-c C-b") #'zuul-switch-build)
> -  (define-key map (kbd "C-c C-.") #'eldoc-mode)
> -  (define-key map (kbd "C-c ]") #'zuul-next-build)
> -  (define-key map (kbd "C-c C-o") #'zuul-open-build-in-browser)
> -  (define-key map (kbd "C-c [") #'zuul-previous-build)
> -  (define-key map (kbd "C-c C-p") #'zuul-previous-command)
> -  (define-key map (kbd "C-c C-n") #'zuul-next-command)
> -  (define-key map (kbd "C-c C-q") #'zuul-quit-build)
> -  (define-key map (kbd "C-c C-s") #'zuul-switch-buildset)
> -  (define-key map (kbd "C-c C-r") #'zuul-run-build-command))
> +(defvar zuul-log-mode-map
> +  (let ((map (make-sparse-keymap)))
> +    (define-key map (kbd "C-c C-b") #'zuul-switch-build)
> +    (define-key map (kbd "C-c C-.") #'eldoc-mode)
> +    (define-key map (kbd "C-c ]") #'zuul-next-build)
> +    (define-key map (kbd "C-c C-o") #'zuul-open-build-in-browser)
> +    (define-key map (kbd "C-c [") #'zuul-previous-build)
> +    (define-key map (kbd "C-c C-p") #'zuul-previous-command)
> +    (define-key map (kbd "C-c C-n") #'zuul-next-command)
> +    (define-key map (kbd "C-c C-q") #'zuul-quit-build)
> +    (define-key map (kbd "C-c C-s") #'zuul-switch-buildset)
> +    (define-key map (kbd "C-c C-r") #'zuul-run-build-command)
> +    map))
>  
>  (provide 'zuul)
>