Re: [elpa] externals/emms e9fa4c095d: * emms.el: reverse the order players are collected

[Stefan Monnier]

> --- a/emms.el
> +++ b/emms.el
> @@ -1511,7 +1511,7 @@ If the track can be played by more than one player, call
>      (mapc
>       #'(lambda (player)
>        (when (funcall (emms-player-get player 'playablep) track)
> -        (push player players)))
> +        (setq players (append players `(,player)))))
>       emms-player-list)
>      (if (< 1 (length players))
>       (emms-players-preference track players)

This changes the code's complexity from O(N) to O(N²) in the number of
players.  Maybe it's not a very big deal, but the standard way to avoid
this is to use `push` inside the loop followed by `nreverse` at the of
the loop.


        Stefan