Re: TypeScript support for tree-sitter (was Re: Call for volunteers: add tree-sitter support to major modes)

[Theodor Thornhill]

Hi and thanks for your time!

> Thanks! Some very minor comments:
>

[...]

> +
>
> I think we should menntion that this mode requires tree-sitter to function.
>

Done

>  
>  * Incompatible Lisp Changes in Emacs 29.1
>  
> diff --git a/lisp/progmodes/typescript-mode.el 
> b/lisp/progmodes/typescript-mode.el
> new file mode 100644
> index 0000000000..363f7d150d
> --- /dev/null
> +++ b/lisp/progmodes/typescript-mode.el
> @@ -0,0 +1,8 @@
> +;;; typescript-mode.el --- tree sitter support for Typescript  -*- 
> lexical-binding: t; -*-
> +
> +;; Copyright (C) 2022 Free Software Foundation, Inc.
> +
> +;; Author     : Theodor Thornhill <theo@thornhill.no>
> +;; Maintainer : Theodor Thornhill <theo@thornhill.no>
> +;; Created    : April 2022
> +;; Keywords   : typescript languages tree-sitter
>
> I think we're suppose to add "This file is part of GNU Emacs" in the
> header.
>

Done

> +
> +;; This program is free software; you can redistribute it and/or modify
> +;; it under the terms of the GNU General Public License as published by
> +;; the Free Software Foundation, either version 3 of the License, or
> +;; (at your option) any later version.
> +

[...]

> +
>
> Regarding below: again, sorry for the nitpick, but could you wrap lines
> to 70 columns?

No need to be sorry - I tried wrapping some more stuff.  Sometimes it
may hurt readability with 70 columns.  I thought 80 was preferred?  In
anycase, it should be better now.

>
> +(defvar typescript-mode--indent-rules
> +  `((tsx


See latest iteration below.


Thanks,

Theo

0001-Add-TypeScript-support-with-tree-sitter.patch
Description: Text Data