[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: CC Mode -> Tree sitter challenge
From: |
Theodor Thornhill |
Subject: |
Re: CC Mode -> Tree sitter challenge |
Date: |
Sat, 05 Nov 2022 16:06:29 +0100 |
On 5 November 2022 15:55:59 CET, Eli Zaretskii <eliz@gnu.org> wrote:
>> From: Theodor Thornhill <theo@thornhill.no>
>> Cc: emacs-devel@gnu.org, casouri@gmail.com, monnier@iro.umontreal.ca
>> Date: Sat, 05 Nov 2022 15:37:58 +0100
>>
>> I took the function 'note_mouse_highlight' from xdisp.c, pushed all
>> lines to column 0 and ran:
>>
>> Keep in mind that the indentation result is not 100% identical, but I
>> doubt that will change anything.
>
>Why isn't it identical? Is it because the indentation code is not yet
>in its final shape?
>
Yes, I have to find each case covered by the language and account for it.
There's nothing inherent to Yuans code, at least I don't think so. There's
still stuff to be done, of course.
>> I'll benchmark everything again when we're satisfied with the
>> behavior. This is only 2 evenings worth of hacking.
>
>OK, thanks. Again, looks good, especially I like how much less GC
>this produces. But note that the, if you subtract the time taken by
>GC, CC Mode is actually slightly faster: 6.5 sec vs 9. I wonder why
>is that.
Interesting. My guess is that there are still some improvement possible in the
indent-region code, considering that part of treesit.el is quite new.
What do you think, Yuan? Any thoughts?
Anyways, I'll keep working on this and see how far I get next coming weeks. At
least in performance it seems I have a good thing going here :-)
Theo
- Re: CC Mode -> Tree sitter challenge, (continued)
- Re: CC Mode -> Tree sitter challenge, Eli Zaretskii, 2022/11/05
- Re: CC Mode -> Tree sitter challenge, Theodor Thornhill, 2022/11/05
- Re: CC Mode -> Tree sitter challenge, Eli Zaretskii, 2022/11/05
- Re: CC Mode -> Tree sitter challenge, Theodor Thornhill, 2022/11/05
- Re: CC Mode -> Tree sitter challenge, Theodor Thornhill, 2022/11/05
- Re: CC Mode -> Tree sitter challenge, Eli Zaretskii, 2022/11/05
- Re: CC Mode -> Tree sitter challenge,
Theodor Thornhill <=
- Re: CC Mode -> Tree sitter challenge, Theodor Thornhill, 2022/11/05
- Re: CC Mode -> Tree sitter challenge, Theodor Thornhill, 2022/11/05
- Re: CC Mode -> Tree sitter challenge, Eli Zaretskii, 2022/11/05
- Re: CC Mode -> Tree sitter challenge, Yuan Fu, 2022/11/05
- Re: CC Mode -> Tree sitter challenge, Theodor Thornhill, 2022/11/06
- Re: CC Mode -> Tree sitter challenge, Yuan Fu, 2022/11/06
- Re: CC Mode -> Tree sitter challenge, Theodor Thornhill, 2022/11/07
Re: CC Mode -> Tree sitter challenge, Stefan Monnier, 2022/11/05