Re: Progress for bug#59314 for emacs-29

[Eli Zaretskii]

> From: Thomas Fitzsimmons <fitzsim@fitzsim.org>
> Cc: emacs-devel@gnu.org,  alexander.adolf@condition-alpha.com
> Date: Wed, 21 Dec 2022 07:54:56 -0500
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> >> From: Thomas Fitzsimmons <fitzsim@fitzsim.org>
> >> Cc: Alexander Adolf <alexander.adolf@condition-alpha.com>
> >> Date: Tue, 20 Dec 2022 21:59:41 -0500
> >> 
> >> Alexander posted the attached patch, which helps with bug#59314.  Can I
> >> push it to the emacs-29 branch?
> >
> > Is this a bug or just a lack of a nice-to-have feature?  If the
> > former, since when do we have this bug?
> >
> > Also, I'd like to reassess this once you have a final version, per
> > Stefan's comments, which avoids tramping a user option.
> 
> OK.  The issue itself, a regression, is fixed by just this part of the
> patch (see long discussion on the bug report):
> 
> diff --git a/lisp/gnus/message.el b/lisp/gnus/message.el
> index e7d11b597b3..6c10a4ae976 100644
> --- a/lisp/gnus/message.el
> +++ b/lisp/gnus/message.el
> @@ -3191,7 +3191,6 @@ message-mode
>      (mail-abbrevs-setup))
>     ((message-mail-alias-type-p 'ecomplete)
>      (ecomplete-setup)))
> -  (add-hook 'completion-at-point-functions #'eudc-capf-complete -1 t)
>    (add-hook 'completion-at-point-functions #'message-completion-function nil 
> t)
>    (unless buffer-file-name
>      (message-set-auto-save-file-name))
> 
> Can I push that?

Yes, thanks.