emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/topspace 9d6f0ef459 099/181: Fix terminal bug and minor


From: ELPA Syncer
Subject: [elpa] externals/topspace 9d6f0ef459 099/181: Fix terminal bug and minor mouse scrolling bug
Date: Tue, 23 Aug 2022 12:58:38 -0400 (EDT)

branch: externals/topspace
commit 9d6f0ef4598c64557d3f859aa322467ea4127a8b
Author: Trevor Pogue <poguete@mcmaster.ca>
Commit: Trevor Pogue <poguete@mcmaster.ca>

    Fix terminal bug and minor mouse scrolling bug
    
    - Fix issue from PR #10 that broke ability to scroll down when in terminal:
      Resolved by making the line height calculations on integers instead of
      floating-point when in terminal.
    
    - Fix minor issue from PR #10 caused when scrolling with mouse:
      When mouse scrolled the buffer all the way down it made the top space
      unexpectedly jump. This was resolved by lowering topspace command hook
      priorities such that the hooks are run sooner in the list.
---
 topspace.el | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/topspace.el b/topspace.el
index 0c826402e2..bee193ba24 100644
--- a/topspace.el
+++ b/topspace.el
@@ -360,7 +360,9 @@ or if the selected window is in a child-frame."
 
 (defun topspace--window-height ()
   "Return the number of screen lines in the selected window rounded up."
-  (float (floor (window-screen-lines))))
+  (if (display-graphic-p)
+      (float (floor (window-screen-lines)))
+    (floor (window-screen-lines))))
 
 (defun topspace--count-pixel-height (start end)
   "Return total pixels between points START and END as if they're both 
visible."
@@ -529,7 +531,7 @@ ARG defaults to 1."
 (defun topspace--add-hooks ()
   "Add hooks defined in `topspace--hook-alist'."
   (dolist (hook-func-pair topspace--hook-alist)
-    (add-hook (car hook-func-pair) (cdr hook-func-pair) 0 t)))
+    (add-hook (car hook-func-pair) (cdr hook-func-pair) -90 t)))
 
 (defun topspace--remove-hooks ()
   "Remove hooks defined in `topspace--hook-alist'."



reply via email to

[Prev in Thread] Current Thread [Next in Thread]