[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] externals/topspace 334cf13ab5 121/181: Internal optimization
From: |
ELPA Syncer |
Subject: |
[elpa] externals/topspace 334cf13ab5 121/181: Internal optimization |
Date: |
Tue, 23 Aug 2022 12:58:40 -0400 (EDT) |
branch: externals/topspace
commit 334cf13ab5be7c1ba301a27e5c8e0da0fffda6eb
Author: Trevor Pogue <poguete@mcmaster.ca>
Commit: Trevor Pogue <poguete@mcmaster.ca>
Internal optimization
Previous commit resolved #12's issue more succinctly,
making #12's solution to its issue unnecessary.
---
topspace.el | 18 +-----------------
1 file changed, 1 insertion(+), 17 deletions(-)
diff --git a/topspace.el b/topspace.el
index dffc299d43..06acd45a0d 100644
--- a/topspace.el
+++ b/topspace.el
@@ -223,23 +223,7 @@ TOTAL-LINES is used in the same way as in `scroll-down'."
(setq total-lines (or total-lines (- (topspace--window-height)
next-screen-context-lines)))
(setq topspace--total-lines-scrolling total-lines)
- (cond
- ((and (= (window-start) 1) (> total-lines 0))
- ;; Prevent "Begining of buffer" error/message when scrolling above
- ;; top line by passing 0 to `scroll-down' when relevant:
- (let ((max-height
- (- (topspace--window-height) (topspace--context-lines)))
- (old-height (topspace--height)))
- (topspace--scroll total-lines)
- ;; But if top space is at its max height, then allow the
- ;; "Begining of buffer" error/message to occur:
- (if (= old-height max-height)
- (list total-lines)
- (list 0))))
- (t ;; if no top space present then we don't have to worry about
- ;; signalling the "Begining of buffer" error/message
- ;; (so can skip the above conditions for avoiding this error)
- (list (topspace--scroll total-lines)))))))
+ (list (topspace--scroll total-lines)))))
(defun topspace--filter-args-scroll-up (&optional total-lines)
"Run before `scroll-up' for scrolling above the top line.
- [elpa] externals/topspace d0e7e89413 094/181: Put topspace-empty-line-indicator inside fringe (#9), (continued)
- [elpa] externals/topspace d0e7e89413 094/181: Put topspace-empty-line-indicator inside fringe (#9), ELPA Syncer, 2022/08/23
- [elpa] externals/topspace 9d6f0ef459 099/181: Fix terminal bug and minor mouse scrolling bug, ELPA Syncer, 2022/08/23
- [elpa] externals/topspace 6d3b5e5cf7 103/181: Update README.md, ELPA Syncer, 2022/08/23
- [elpa] externals/topspace df7cb1ce4f 107/181: Bump version: 0.1.2 → 0.2.0, ELPA Syncer, 2022/08/23
- [elpa] externals/topspace edb0d582ae 108/181: Update Changelog, ELPA Syncer, 2022/08/23
- [elpa] externals/topspace c21ceb5e3a 109/181: Set back Unreleased as recent version in changelog, ELPA Syncer, 2022/08/23
- [elpa] externals/topspace e3cd398678 112/181: Fix bug caused by #11 when scrolling with topspace disabled, ELPA Syncer, 2022/08/23
- [elpa] externals/topspace cb9dbf5c0f 114/181: Start adding tests, ELPA Syncer, 2022/08/23
- [elpa] externals/topspace af98947c27 115/181: Prevent "Beginning of buffer" error message (#12), ELPA Syncer, 2022/08/23
- [elpa] externals/topspace ba275f7c94 119/181: Fix off-by-one-line scroll bug at top of buffer introduced in #10, ELPA Syncer, 2022/08/23
- [elpa] externals/topspace 334cf13ab5 121/181: Internal optimization,
ELPA Syncer <=
- [elpa] externals/topspace f5d01b58f8 127/181: Update Changelog, ELPA Syncer, 2022/08/23
- [elpa] externals/topspace 4724b926a4 134/181: Add continuous integration and coverage, ELPA Syncer, 2022/08/23
- [elpa] externals/topspace a4c5873fb4 125/181: Update Changelog, ELPA Syncer, 2022/08/23
- [elpa] externals/topspace d376bca4c8 130/181: Internal refactoring, ELPA Syncer, 2022/08/23
- [elpa] externals/topspace e6cc9081a2 128/181: Add `topspace-height` function for use by external packages (#15), ELPA Syncer, 2022/08/23
- [elpa] externals/topspace 7a0d565b68 126/181: Set back changelog head to `Unreleased`, ELPA Syncer, 2022/08/23
- [elpa] externals/topspace f79b07c982 129/181: Update Changelog, ELPA Syncer, 2022/08/23
- [elpa] externals/topspace 64bbce19a0 136/181: Add coverage badge to readme, ELPA Syncer, 2022/08/23
- [elpa] externals/topspace 0541624721 138/181: Update test.yml, ELPA Syncer, 2022/08/23
- [elpa] externals/topspace 0e4b28f3d5 142/181: Refresh cached coveralls badge image in readme, ELPA Syncer, 2022/08/23