[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Add NO-STATS switch to org-get-heading
From: |
Adam Porter |
Subject: |
Re: [PATCH] Add NO-STATS switch to org-get-heading |
Date: |
Fri, 13 Mar 2020 13:50:33 -0500 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) |
Please don't add more arguments to org-get-heading. It used to have 2,
then it had 4, and now you want to add a 5th. Every time the function's
signature changes, it breaks code in third-party packages and user code
in random places, which requires the addition of messy compatibility
code and intermediate functions that do nothing but wrap org-get-heading
with a certain number of arguments.
It would be much preferable to make a new function that uses keyword
arguments so the addition of more arguments won't affect existing code.
Maybe it could be called org-entry-heading.