Re: [PATCH] ob-sql.el: Add support for SAP HANA

[Kyle Meyer]

Robin Campbell Joy writes:

> Subject: [PATCH] ob-sql.el: Add support for SAP HANA

Thanks for the update.  Pushed (b241c126b).

> diff --git a/testing/lisp/test-ob-sql.el b/testing/lisp/test-ob-sql.el
[...]
> +
> +(require 'org-test)
> +(require 'ob-sql)

I've dropped these two lines.

For the first one, currently only four test files load org-test
explicitly, while the majority of the tests rely on org-test being
loaded as part of the setup.

For the second, nearly all ob-LANG tests check whether the corresponding
ob- feature is available, signaling missing-test-dependency if it's not.
Which ob- libraries are loaded/tested can then controlled by the
Makefile variable BTEST_OB_LANGUAGES.  Explicitly loading the ob- file
goes against that setup, making the (featurep ...) check that follows
always return non-nil,

I'm guessing this line was adjusted from test-ob-sqlite, which appears
to be the one [*] ob-LANG test file that gets this wrong.  I've
pushed another commit to adjust it.

[*] I believe ob-emacs-lisp is an intended exception.

> +(unless (featurep 'ob-sql)
> +  (signal 'missing-test-dependency "Support for sql code blocks"))