Re: [PATCH] lisp/ob-octave.el, was [PATCH] rfc: using ert-deftest with side-effects

[Ihor Radchenko]

Leo Butler <Leo.Butler@umanitoba.ca> writes:

>> Apparently, `sleep-for' 1 second was not enough, and I decided to remove
>> checking file size completely.
>
> Hello Ihor,
>
> Is there an environment variable that could be used to determine is the
> tests are being run on sourcehut? This would let us cut out that test on
> sourcehut, while still keeping it elsewhere.

No, we have nothing like this.

In theory, we can bind something in
https://git.sr.ht/~bzg/org-mode-tests/tree/master/item/.builds/init.el,
but I am not sure if it is a good idea.

The tests are failing not because something wrong in the CI machine, but
simply because CI machine is slow. You can get similar issue when
running Org tests on an actual proper old PC or simply when someone is
running CPU-heavy process alongside with Org tests.

So, I do not think that creating exceptions for CI is a good idea.

>> https://builds.sr.ht/~bzg/job/914954
>> 2 unexpected results:
>>    FAILED  ob-octave/graphics-file  ((should-not (get-buffer "*Org-Babel
>>    Error Output*")) :form (get-buffer "*Org-Babel Error Output*") :value
>>    #<killed buffer>) 
>>    FAILED  ob-octave/graphics-file-space  ((should-not (get-buffer
>>    "*Org-Babel Error Output*")) :form (get-buffer "*Org-Babel Error
>>    Output*") :value #<killed buffer>) 
>>
>> As you can see *Org-Babel Error Output* buffer does not exist when
>> running the test.
>>
>> Leo, could you please take a look?
>
> An earlier test is creating that *Org Babel Error Output* buffer. That
> is killed on the first test, before the test is actually run. But
> GET-BUFFER behaves in an undocumented way: it returns a non-nil value,
> #<killed buffer>. To remedy that, I have wrapped the calls in
> BUFFER-LIVE-P.

This is not undocumented. The killed buffers still exists as Elisp
objects:

28.10 Killing Buffers
=====================

“Killing a buffer” makes its name unknown to Emacs and makes the memory
space it occupied available for other use.

   The buffer object for the buffer that has been killed remains in
existence as long as anything refers to it, but it is specially marked
so that you cannot make it current or display it.  Killed buffers retain
their identity, however; if you kill two distinct buffers, they remain
distinct according to ‘eq’ although both are dead.


> See the attached patch.

Thanks!
Installed onto bugfix.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=41ebc2e40

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>