[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] lisp/ob-octave.el, was [PATCH] rfc: using ert-deftest with s
From: |
Leo Butler |
Subject: |
Re: [PATCH] lisp/ob-octave.el, was [PATCH] rfc: using ert-deftest with side-effects |
Date: |
Wed, 11 Jan 2023 15:51:11 -0600 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) |
On Wed, Jan 11 2023, Ihor Radchenko <yantar92@posteo.net> wrote:
> Leo Butler <Leo.Butler@umanitoba.ca> writes:
>
>>>>>> Leo, could you please take a look?
>>>>>
>>>>> An earlier test is creating that *Org Babel Error Output* buffer.
>>>
>>> I will try to look into improving the tests so that we can trap the test(s)
>>> that is(are) creating that error buffer.
>>
>> See the attachment. There are four test failures that are currently
>> untrapped. I also see the `buffer-live-p' bug.
>
> It looks like `buffer-live-p' is not a bug, but rather the result of
> backtrace being printed upon executing `kill-buffer' in unwind-protect
> form from the test body: (1) test fails; (2) unwind-protect executes
> kill-buffer; (3) backtrace is printed with "killed" buffer object.
Yes, that seems reasonable.
>
> So, the test failure is real.
>
> 94980226-D29A-4969-8640-1143A1979164@bundesbrandschatzamt.de">https://orgmode.org/list/94980226-D29A-4969-8640-1143A1979164@bundesbrandschatzamt.de
> might be related.
Ihor,
How do you want to treat the patch that was included? I think we should
have something like that to catch errors like these. And the failing
tests should be marked as known failures (that need to be fixed,
obviously). I note that both failures 3 & 4 are related to org's
built-in features.
Leo
- Re: [PATCH] lisp/ob-octave.el, was [PATCH] rfc: using ert-deftest with side-effects, Ihor Radchenko, 2023/01/02
- Re: [PATCH] lisp/ob-octave.el, was [PATCH] rfc: using ert-deftest with side-effects, Leo Butler, 2023/01/05
- Re: [PATCH] lisp/ob-octave.el, was [PATCH] rfc: using ert-deftest with side-effects, Ihor Radchenko, 2023/01/06
- Re: [PATCH] lisp/ob-octave.el, was [PATCH] rfc: using ert-deftest with side-effects, Leo Butler, 2023/01/06
- Re: [PATCH] lisp/ob-octave.el, was [PATCH] rfc: using ert-deftest with side-effects, Leo Butler, 2023/01/10
- Re: [PATCH] lisp/ob-octave.el, was [PATCH] rfc: using ert-deftest with side-effects, Ihor Radchenko, 2023/01/11
- Re: [PATCH] lisp/ob-octave.el, was [PATCH] rfc: using ert-deftest with side-effects,
Leo Butler <=
- Re: [PATCH] lisp/ob-octave.el, was [PATCH] rfc: using ert-deftest with side-effects, Ihor Radchenko, 2023/01/12
- Re: [PATCH] lisp/ob-octave.el, was [PATCH] rfc: using ert-deftest with side-effects, Ihor Radchenko, 2023/01/13
- Re: [PATCH] lisp/ob-octave.el, was [PATCH] rfc: using ert-deftest with side-effects, Leo Butler, 2023/01/14
- Re: [PATCH] lisp/ob-octave.el, was [PATCH] rfc: using ert-deftest with side-effects, Ihor Radchenko, 2023/01/14
- Re: [PATCH] lisp/ob-octave.el, was [PATCH] rfc: using ert-deftest with side-effects, Max Nikulin, 2023/01/14
- Re: [PATCH] lisp/ob-octave.el, was [PATCH] rfc: using ert-deftest with side-effects, Ihor Radchenko, 2023/01/23
- Re: [PATCH] lisp/ob-octave.el, was [PATCH] rfc: using ert-deftest with side-effects, Leo Butler, 2023/01/24
- Re: [PATCH] lisp/ob-octave.el, was [PATCH] rfc: using ert-deftest with side-effects, Ihor Radchenko, 2023/01/07