Re: [emms-help] [Yoni Rabkin] Re: Patch: emms-playlist-tracks-in-region

[Yoni Rabkin]

"Fran Burstall (Gmail)" <address@hidden> writes:

> On Sat, 6 Oct 2018 at 09:11, Fran Burstall (Gmail) <
> address@hidden> wrote:
>
>    
>    
>     On Sat, 6 Oct 2018 at 03:31, Mike Kazantsev <address@hidden
>     > wrote:
>    
>         On Sat, 6 Oct 2018 00:03:59 +0100
>         Fran Burstall <address@hidden> wrote:
>        
>         > Have a look at a new version on the emms-playlist-limit
>         branch.
>         >
>         > Now "/ d" filters by regexp on what the playlist buffer
>         shows (strictly, on
>         > what `emms-track-description-function' returns for each
>         track).  I hope
>         > this gives what Mike wants while addressing Yoni's concern.
>        
>         Indeed it works and is very useful, thanks!
>        
>         Also very intuitive to me how to use such limiting in
>         general,
>         as it's same pattern as with ibuffer and such using the /
>         key.
>        
>         One random small thing I've noticed at the top of "git log -u
>         origin/emms-playlist-limit":
>        
>           diff --git a/lisp/emms-playlist-limit.el b/lisp/
>         emms-playlist-limit.el
>           index 5f0cb28..9fcc74b 100644
>           --- a/lisp/emms-playlist-limit.el
>           +++ b/lisp/emms-playlist-limit.el
>           @@ -45,6 +45,7 @@
>            ;;  / a   emms-playlist-limit-to-info-artist
>            ;;  / b   emms-playlist-limit-to-info-album
>            ;;  / c   emms-playlist-limit-to-info-composer
>           +;;  / d         emms-playlist-limit-to-description
>            ;;  / g   emms-playlist-limit-to-info-genre
>            ;;  / n   emms-playlist-limit-to-name
>            ;;  / p   emms-playlist-limit-to-info-performer
>           @@ -79,11 +80,11 @@ the current playlist." attribute)
>        
>         ^^^ it looks like a tab slipped-in there among spaces or
>         vice-versa.
>    
>    
>     Well spotted.  Now fixed.
>
>
> OK to merge this into master?

Please do.

More generally: unless it's a terribly dramatic change, please feel free
to merge into master at your discretion.

-- 
   "Cut your own wood and it will warm you twice"