[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: No sound if emms-play-dired is run while another track is paused
From: |
Yoni Rabkin |
Subject: |
Re: No sound if emms-play-dired is run while another track is paused |
Date: |
Sat, 19 Jun 2021 08:54:12 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) |
Mike Kazantsev <mk.fraggod@gmail.com> writes:
> On Sat, 19 Jun 2021 06:19:16 +0500
> Mike Kazantsev <mk.fraggod@gmail.com> wrote:
>
>> On Fri, 18 Jun 2021 16:00:28 -0400
>> Greg Farough <gregf@gnu.org> wrote:
>>
>> > On Fri, Jun 18 2021, Yoni Rabkin <yoni@rabkins.net> wrote:
>> >
>> > > Now I'm having an issue where occasionally I'll need to select a track
>> > > twice in order for it to play, especially after a while of not playing
>> > > anything. I reverted to d4d9171ce and isn't happening there.
>> > >
>> > > I haven't looked into it yet.
>> > >
>> > > Anyone else experiencing this?
>> >
>> > Actually, yes. Once again I thought it was a quirk of my system, but
>> > the same thing has been happening to me on 7.4.
>
>
>> One thing there that I've just noticed is that
>> 02915f7aa24d27d717ff4821a58f791cffcc174c seem to have produced this code:
>>
>> (start-func (lambda ()
>> (emms-player-mpv-cmd start-cmd
>> (apply-partially #'emms-player-mpv-start-error-handler ',start-cmd))
>> ...
>>
>> Where previously lambda was in quasiquotes, ',start-cmd made sense,
>> but now I think it's broken, and if initial start-cmd fails for some reason,
>> that "restart stuff and try again" fallback won't be invoked correctly.
>
> Looks like it works either way, but fixed it anyway in 1ce322a,
> and while testing how it works, found a way to reproduce issue like one
> mentioned above - see below.
The fix works for me, thank you, and thank you as well for the fast
reply. I release the fix in version 7.5 and it is on its way to
elpa. I've also made note of the debugging commands you've brought up so
that I can provide more verbose problem reports for mpv in future.
--
"Cut your own wood and it will warm you twice"
- Re: No sound if emms-play-dired is run while another track is paused, (continued)
- Re: No sound if emms-play-dired is run while another track is paused, Mike Kazantsev, 2021/06/14
- Re: No sound if emms-play-dired is run while another track is paused, Yoni Rabkin, 2021/06/14
- Re: No sound if emms-play-dired is run while another track is paused, Grant Shoshin Shangreaux, 2021/06/14
- Re: No sound if emms-play-dired is run while another track is paused, Yoni Rabkin, 2021/06/18
- Re: No sound if emms-play-dired is run while another track is paused, Greg Farough, 2021/06/18
- Re: No sound if emms-play-dired is run while another track is paused, Mike Kazantsev, 2021/06/18
- Re: No sound if emms-play-dired is run while another track is paused, Mike Kazantsev, 2021/06/19
- Re: No sound if emms-play-dired is run while another track is paused,
Yoni Rabkin <=