Re: [glob2-devel] Pull request policy

[Kyle L]

On the one hand I was avoiding Travis CI because they were bought by Idera, INC who fired most of the devs and basically showed their plan is to wring every last penny out of it until people stop using it since they won't do a lot of updates to it. The fun of private equity companies. On the other hand, we're not doing anything sensitive, he's already made the script, and it saves some work. Unless there are objections, I'll setup an official travis-ci project for us tomorrow.

Kyle

On Sat, Dec 28, 2019 at 10:08 AM Stéphane Magnenat <address@hidden> wrote:

On 28.12.19 17:02, Kyle L wrote:
> When people submit pull requests we should definitely always have at
> least one person review before merging. We should make sure that it's
> quality code, it's helping push the project forward in the direction
> we're all thinking about, etc. The other thing we should do is add in
> a CI system that automatically checks if the whole project still
> builds on linux, windows, and mac. I was looking at Gitlab CI and
> CircleCI. Any preferences there?

No preference personally as I do not have relevant experience.

Someone just opened a PR with a travis CI integration:

https://github.com/Globulation2/glob2/pull/6

cheers,

Stéphane

--
http://stephane.magnenat.net


_______________________________________________
glob2-devel mailing list
address@hidden
https://lists.nongnu.org/mailman/listinfo/glob2-devel