gnokii-users
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Opensync-users] [PATCH] Account for phonebook blocks not sent due t


From: Pawel Kot
Subject: Re: [Opensync-users] [PATCH] Account for phonebook blocks not sent due to limited packet space
Date: Mon, 9 Jul 2007 21:50:06 +0200

Applied, thanks.

take care,
pkot

On 7/9/07, Keith Packard <address@hidden> wrote:
---
 common/phones/nk6510.c |   34 ++++++++++++++++++++--------------
 1 files changed, 20 insertions(+), 14 deletions(-)

diff --git a/common/phones/nk6510.c b/common/phones/nk6510.c
index e519f8a..aba8a7f 100644
--- a/common/phones/nk6510.c
+++ b/common/phones/nk6510.c
@@ -2152,15 +2152,19 @@ static gn_error NK6510_GetSpeedDial(gn_data *data, 
struct gn_statemachine *state
        return NK6510_ReadPhonebookLocation(data, state, NK6510_MEMORY_SPEEDDIALS, 
data->speed_dial->number);
 }

-static unsigned char PackBlock(u8 id, u8 size, u8 no, u8 *buf, u8 *block, 
unsigned int maxsize)
+static unsigned char PackBlock(u8 id, u8 size, int *no, u8 *buf, u8 *block, 
unsigned int maxsize)
 {
-       if (size + 5 > maxsize) return 0;
+       if (size + 5 > maxsize) {
+               fprintf (stderr, "Block packing failure -- not enough space\n");
+               return 0;
+       }
        *(block++) = id;
        *(block++) = 0;
        *(block++) = 0;
        *(block++) = size + 5;
        *(block++) = 0xff; /* no; */
        memcpy(block, buf, size);
+       ++*no;
        return (size + 5);
 }

@@ -2172,6 +2176,7 @@ static gn_error NK6510_SetSpeedDial(gn_data *data, struct 
gn_statemachine *state
                                 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
                                 0x01}; /* blocks */
        char string[40];
+       int block;

        dprintf("Setting speeddial...\n");
        req[13] = (data->speed_dial->number >> 8);
@@ -2188,7 +2193,8 @@ static gn_error NK6510_SetSpeedDial(gn_data *data, struct 
gn_statemachine *state
                string[7] = 0x05;
        memcpy(string + 8, "\x0B\x02", 2);

-       PackBlock(0x1a, 10, 1, string, req + 22, 40 - 22);
+       block = 1;
+       PackBlock(0x1a, 10, &block, string, req + 22, 40 - 22);
        SEND_MESSAGE_BLOCK(NK6510_MSG_PHONEBOOK, 38);
 }

@@ -2223,7 +2229,7 @@ static gn_error SetCallerBitmap(gn_data *data, struct 
gn_statemachine *state)
        string[0] = data->bitmap->number + 1;
        string[1] = 0;
        string[2] = 0x55;
-       count += PackBlock(0x1e, 3, block++, string, req + count, 400 - count);
+       count += PackBlock(0x1e, 3, &block, string, req + count, 400 - count);

        /* Logo */
        string[0] = data->bitmap->width;
@@ -2231,13 +2237,13 @@ static gn_error SetCallerBitmap(gn_data *data, struct 
gn_statemachine *state)
        string[2] = string[3] = 0x00;
        string[4] = 0x7e;
        memcpy(string + 5, data->bitmap->bitmap, data->bitmap->size);
-       count += PackBlock(0x1b, data->bitmap->size + 5, block++, string, req + 
count, 400 - count);
+       count += PackBlock(0x1b, data->bitmap->size + 5, &block, string, req + 
count, 400 - count);

        /* Name */
        i = strlen(data->bitmap->text);
        i = char_unicode_encode((string + 1), data->bitmap->text, i);
        string[0] = i;
-       count += PackBlock(0x07, i + 1, block++, string, req + count, 400 - 
count);
+       count += PackBlock(0x07, i + 1, &block, string, req + count, 400 - 
count);

        /* Ringtone */
        if(data->bitmap->ringtone<0) {
@@ -2260,7 +2266,7 @@ static gn_error SetCallerBitmap(gn_data *data, struct 
gn_statemachine *state)
                string[9] = 0x00;
                string[10] = 0x07;
        }
-       count += PackBlock(0x37, 11, block++, string, req + count, 400-count);
+       count += PackBlock(0x37, 11, &block, string, req + count, 400-count);

        req[21] = block;
        SEND_MESSAGE_BLOCK(NK6510_MSG_PHONEBOOK, count);
@@ -2337,13 +2343,13 @@ static gn_error NK6510_WritePhonebookLocation(gn_data 
*data, struct gn_statemach
                /* Name */
                j = char_unicode_encode((string + 1), entry->name, 
strlen(entry->name));
                string[0] = j;
-               count += PackBlock(0x07, j + 1, block++, string, req + count, 
GN_PHONEBOOK_ENTRY_MAX_LENGTH - count);
+               count += PackBlock(0x07, j + 1, &block, string, req + count, 
GN_PHONEBOOK_ENTRY_MAX_LENGTH - count);

                /* Group */
                string[0] = entry->caller_group + 1;
                string[1] = 0;
                string[2] = 0x55;
-               count += PackBlock(0x1e, 3, block++, string, req + count, 
GN_PHONEBOOK_ENTRY_MAX_LENGTH - count);
+               count += PackBlock(0x1e, 3, &block, string, req + count, 
GN_PHONEBOOK_ENTRY_MAX_LENGTH - count);
                /* We don't require the application to feel in any subentry.
                 * if it is not filled in, let's take just one number we have.
                 */
@@ -2354,7 +2360,7 @@ static gn_error NK6510_WritePhonebookLocation(gn_data 
*data, struct gn_statemach
                        j = char_unicode_encode((string + 5), entry->number, j);
                        string[j + 1] = 0;
                        string[4] = j;
-                       count += PackBlock(0x0b, j + 5, block++, string, req + 
count, GN_PHONEBOOK_ENTRY_MAX_LENGTH - count);
+                       count += PackBlock(0x0b, j + 5, &block, string, req + 
count, GN_PHONEBOOK_ENTRY_MAX_LENGTH - count);
                } else {
                        /* Default Number */
                        defaultn = 999;
@@ -2369,7 +2375,7 @@ static gn_error NK6510_WritePhonebookLocation(gn_data 
*data, struct gn_statemach
                                j = char_unicode_encode((string + 5), 
entry->subentries[defaultn].data.number, j);
                                string[j + 1] = 0;
                                string[4] = j;
-                               count += PackBlock(0x0b, j + 5, block++, 
string, req + count, GN_PHONEBOOK_ENTRY_MAX_LENGTH - count);
+                               count += PackBlock(0x0b, j + 5, &block, string, 
req + count, GN_PHONEBOOK_ENTRY_MAX_LENGTH - count);
                        }
                        /* Rest of the numbers */
                        for (i = 0; i < entry->subentries_count; i++)
@@ -2391,7 +2397,7 @@ static gn_error NK6510_WritePhonebookLocation(gn_data 
*data, struct gn_statemach
                                                j = char_unicode_encode((string + 
5), entry->subentries[i].data.number, j);
                                                string[j + 1] = 0;
                                                string[4] = j;
-                                               count += PackBlock(0x0b, j + 5, 
block++, string, req + count, GN_PHONEBOOK_ENTRY_MAX_LENGTH - count);
+                                               count += PackBlock(0x0b, j + 5, 
&block, string, req + count, GN_PHONEBOOK_ENTRY_MAX_LENGTH - count);
                                        }
                                        break;
                                case GN_PHONEBOOK_ENTRY_Date:
@@ -2414,7 +2420,7 @@ static gn_error NK6510_WritePhonebookLocation(gn_data 
*data, struct gn_statemach
                                        j = char_unicode_encode((string + 1), 
entry->subentries[i].data.number, j);
                                        string[j + 1] = 0;
                                        string[0] = j;
-                                       count += 
PackBlock(entry->subentries[i].entry_type, j + 1, block++, string, req + count, 
GN_PHONEBOOK_ENTRY_MAX_LENGTH - count);
+                                       count += 
PackBlock(entry->subentries[i].entry_type, j + 1, &block, string, req + count, 
GN_PHONEBOOK_ENTRY_MAX_LENGTH - count);
                                        break;
                                }
                        /* Addresses */
@@ -2449,7 +2455,7 @@ static gn_error NK6510_WritePhonebookLocation(gn_data 
*data, struct gn_statemach
                                                j = char_unicode_encode((string + 
1), entry->subentries[i].data.number, j);
                                                string[j + 1] = 0;
                                                string[0] = j + 2;
-                                               count += 
PackBlock(entry->subentries[i].entry_type, j + 1, block++, string, req + count, 
GN_PHONEBOOK_ENTRY_MAX_LENGTH - count);
+                                               count += 
PackBlock(entry->subentries[i].entry_type, j + 1, &block, string, req + count, 
GN_PHONEBOOK_ENTRY_MAX_LENGTH - count);
                                                break;
                                        default:
                                                break;
--
1.5.2.2


-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
Opensync-users mailing list
address@hidden
https://lists.sourceforge.net/lists/listinfo/opensync-users



--
Pawel Kot




reply via email to

[Prev in Thread] Current Thread [Next in Thread]