Re: [Opensync-users] [PATCH] Delete message when write fails

[Keith Packard]

On Mon, 2007-07-09 at 19:35 +0200, Pawel Kot wrote:
> Hi,
> 
> On 7/9/07, Keith Packard <address@hidden> wrote:
> > @@ -2468,7 +2469,11 @@ static gn_error 
> > NK6510_WritePhonebookLocation(gn_data > -       
> > SEND_MESSAGE_BLOCK(NK6510_MSG_PHONEBOOK, count);
> > +       if (sm_message_send (count, NK6510_MSG_PHONEBOOK, req, state)) 
> > return GN_ERR_NOTREADY;
> > +       error = sm_block (NK6510_MSG_PHONEBOOK, data, state);
> > +       if (error)
> > +               (void) NK6510_DeletePhonebookLocation(data, state);
> > +       return error;
> 
> I'm not sure why you need this. Did you have a case when write failed
> but wrote the entry? Please show the log. The above may cause a
> problem when overwriting existing entries.

Oh, right, I intended to remove this code. I was having trouble with the
phone refusing to accept memory write requests, that was caused by the
phone getting quite confused and thinking that the internal memory was
full. Please don't use this patch.

-- 
address@hidden

signature.asc
Description: This is a digitally signed message part