[Gnu-arch-users] [PATCH] Bug #7072! (Was: Bug? Patchlogs "lacking inventory ids".)

[Jan Hudec]

On Sat, Jan 03, 2004 at 18:23:17 +0100, Jan Hudec wrote:
> > I have built a branch of an old archive, replaced tag: with arch-tag:
> > everywhere and changed implicit tagging method with tagline. And started
> > to get this:
> > 
> > address@hidden:~/dev/ucw-scheme-library$ tla tree-lint
> > These apparent source files lack inventory ids:
> > 
> > {arch}/ucw-scheme-library/ucw-scheme-library--mainline/ucw-scheme-library--mainline--0.1/address@hidden
> > {arch}/ucw-scheme-library/ucw-scheme-library--mainline/ucw-scheme-library--mainline--0.1/address@hidden/patch-log
> > {arch}/ucw-scheme-library/ucw-scheme-library--mainline/ucw-scheme-library--mainline--0.1/address@hidden/patch-log/base-0
> > {arch}/ucw-scheme-library/ucw-scheme-library--mainline/ucw-scheme-library--mainline--0.1/address@hidden/patch-log/patch-1
> > 
> > (address@hidden/ucw-scheme-library--mainline--0.1 is
> > the tagged revision, current tree version is
> > address@hidden/ucw-scheme-library--main--0.2)
> > 
> > Can this be result of changing tagging method from implicit to tagline
> > and if so, how can it be fixed?
> 
> Yes, it's definitely a bug! It does not work because of the '0'
> character in the e-mail address! But it's a perfectly valud e-mail
> address.

And the following patch fixes it.

--- tla-20040103/src/tla/libarch/inv-ids.c.orig 2004-01-03 12:42:16.000000000 
+0100
+++ tla-20040103/src/tla/libarch/inv-ids.c      2004-01-03 19:08:19.000000000 
+0100
@@ -1165,7 +1165,7 @@
     {
       int re_error;
 
-      re_error = regcomp (&pattern, 
"^(.*/)?(\\{arch\\}(/[a-zA-Z=][^/~]*)*|\\{arch\\}/\\.arch-project-tree)$", 
REG_EXTENDED);
+      re_error = regcomp (&pattern, 
"^(.*/)?(\\{arch\\}(/[a-zA-Z0-9=-][^/~]*)*|\\{arch\\}/\\.arch-project-tree)$", 
REG_EXTENDED);
       invariant (!re_error);
       compiled = 1;
     }

PS: Filed as a bug #7072 on savannah.

-------------------------------------------------------------------------------
                                                 Jan 'Bulb' Hudec 
<address@hidden>