Re: [Gnu-arch-users] [BUG] mini patch for pfs-dav.c and libneon GNU TLS work

[Aleix Conchillo Flaque]

John Meinel <address@hidden> writes:

>
> Meaning, default to 80, unless we are sure this should be 443. The way
> the patch was submitted states "default to 443" unless we know we
> should be on 80.
>
> I don't know for sure. But I would say, given any port to pick as
> default, go with 80.
>
> I don't know what strings would exist in dav_scheme, though, to really
> recommend a specific fix.
>

As I see it, I treat it like a switch case, where the "default" is 80.

Anyway, I think it doesn't matter, because only http and https strings are
allowed, so there are just two cases. See this function in pfs-dav.c:

int
arch_pfs_dav_supported_protocol (t_uchar * uri)
{
  if (!str_cmp_prefix ("http:", uri) ||
      !str_cmp_prefix ("https:", uri))
    return 1;
  else
    return 0;
}

Eventhough, the patch is so small that the merger can fix it in some
other way. Right now, I'm changing it so it doesn't have to compare
the strings again, it's already done at the beginning of the
arch_pfs_dav_connect function (see next message).

Best regards,

aleix

pgptwxVp_r721.pgp
Description: PGP signature