Re: [Gnu-arch-users] [BUG] mini patch for pfs-dav.c and libneon GNU TLS work

[Aleix Conchillo Flaque]

Matthew Dempsky <address@hidden> writes:

> (I might not be the one to merge your patch, but I thought I'd offer
> some commentary.)
>

All comentaries are welcome ;).

>
> Thanks for the fix.  Your explanation seemed a little awkward, but a
> bit of googling clarified it.  (For some strange reason I thought
> https defaulted to 8080 not 443, *shrug*.)
>

You're welcome. Port 8080 is for proxies.

>
> It is.  In the future you can prepend your message topic with [BUG] if
> you're just reporting a bug or [MERGE REQUEST] if you have an arch
> revision somewhere with the patch.
>
[snip]

Ok. I should have looked at the mailing list archives before and see
how it was being done.

>
> It's not consistantly applied through out the source code, but arch
> uses the GNU coding style which means a space before all opening
> parentheses.  We're inconsistant enough that we don't need to be any
> more.
>
> Don't get me wrong, I'm not attacking you about this because it's not
> a big deal for an O(10) LOC patch (and I'm sure whoever merges it can
> trivially fix it), just letting you know for any future patches you
> submit.
>

Again, no problem, I think that as a GNU package, it should have the
GNU coding style, I will tell Emacs to help me on this :).

Regarding the patch, I've setup a public archive so the merger will
get the patch easily. The archive is in:

http://tao.uab.es/~aleix/archives/2004

The patch is in: tla--aleix--1.3--patch-2

As I said in the other mail, I've changed the fix. The string
comparisons where already done before, so I think is better to put the
initial port settings there. See below:

--- orig/libarch/pfs-dav.c
+++ mod/libarch/pfs-dav.c
@@ -152,11 +152,13 @@

   if (!str_cmp_prefix ("http://";, uri))
     {
+      answer->dav_port = 80;
       answer->dav_scheme = str_save (0, "http");
       host = str_save (0, uri + sizeof ("http://";) - 1);
     }
   else if (!str_cmp_prefix ("https://";, uri))
     {
+      answer->dav_port = 443;
       answer->dav_scheme = str_save (0, "https");
       host = str_save (0, uri + sizeof ("https://";) - 1);
     }

Thanks for all your comments. I'll take them into account next time.

Best regards,

aleix

pgpIcSS3xWRvu.pgp
Description: PGP signature